Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set versioning build flags in the goreleaser #131

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

dusannosovic-ethernal
Copy link

Description

This pull request incorporates modifications that establish versioning build flags within Goreleaser.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Copy link

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, take a look to this .goreleaser config (https://github.com/0xPolygon/agglayer/blob/main/.goreleaser.yaml#L10-L25), it can be simplified (realized it when work on the agglayer repo).

.goreleaser.yml Outdated Show resolved Hide resolved
.goreleaser.yml Outdated Show resolved Hide resolved
.goreleaser.yml Outdated Show resolved Hide resolved
.goreleaser.yml Outdated Show resolved Hide resolved
@Stefan-Ethernal Stefan-Ethernal merged commit c85df85 into develop Mar 12, 2024
9 of 10 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the set-versioning-build-flags-goreleaser branch March 12, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants